Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: ui/views/border.h

Issue 2475033003: Add ability to specify extra insets for a view via its border. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/system/user/user_view.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_BORDER_H_ 5 #ifndef UI_VIEWS_BORDER_H_
6 #define UI_VIEWS_BORDER_H_ 6 #define UI_VIEWS_BORDER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 int right); 66 int right);
67 67
68 // Creates a border of the specified color, and specified thickness on each 68 // Creates a border of the specified color, and specified thickness on each
69 // side. 69 // side.
70 static std::unique_ptr<Border> CreateSolidSidedBorder(int top, 70 static std::unique_ptr<Border> CreateSolidSidedBorder(int top,
71 int left, 71 int left,
72 int bottom, 72 int bottom,
73 int right, 73 int right,
74 SkColor color); 74 SkColor color);
75 75
76 // Adds extra, unpainted insets to |border|.
sky 2016/11/03 19:24:49 This seems like a nice way to avoid changing all b
Evan Stade 2016/11/04 03:16:39 OK, I tried (I also tried some ASCII art but gave
77 static std::unique_ptr<Border> AddInteriorPadding(
78 std::unique_ptr<Border> border,
79 const gfx::Insets& insets);
80
76 // Creates a Border from the specified Painter. 81 // Creates a Border from the specified Painter.
77 // |insets| define size of an area allocated for a Border. 82 // |insets| define size of an area allocated for a Border.
78 static std::unique_ptr<Border> CreateBorderPainter( 83 static std::unique_ptr<Border> CreateBorderPainter(
79 std::unique_ptr<Painter> painter, 84 std::unique_ptr<Painter> painter,
80 const gfx::Insets& insets); 85 const gfx::Insets& insets);
81 86
82 // Renders the border for the specified view. 87 // Renders the border for the specified view.
83 virtual void Paint(const View& view, gfx::Canvas* canvas) = 0; 88 virtual void Paint(const View& view, gfx::Canvas* canvas) = 0;
84 89
85 // Returns the border insets. 90 // Returns the border insets.
86 virtual gfx::Insets GetInsets() const = 0; 91 virtual gfx::Insets GetInsets() const = 0;
87 92
88 // Returns the minimum size this border requires. Note that this may not be 93 // Returns the minimum size this border requires. Note that this may not be
89 // the same as the insets. For example, a Border may paint images to draw 94 // the same as the insets. For example, a Border may paint images to draw
90 // some graphical border around a view, and this would return the minimum size 95 // some graphical border around a view, and this would return the minimum size
91 // such that these images would not be clipped or overlapping -- but the 96 // such that these images would not be clipped or overlapping -- but the
92 // insets may be larger or smaller, depending on how the view wanted its 97 // insets may be larger or smaller, depending on how the view wanted its
93 // content laid out relative to these images. 98 // content laid out relative to these images.
94 virtual gfx::Size GetMinimumSize() const = 0; 99 virtual gfx::Size GetMinimumSize() const = 0;
95 100
96 private: 101 private:
97 DISALLOW_COPY_AND_ASSIGN(Border); 102 DISALLOW_COPY_AND_ASSIGN(Border);
98 }; 103 };
99 104
100 } // namespace views 105 } // namespace views
101 106
102 #endif // UI_VIEWS_BORDER_H_ 107 #endif // UI_VIEWS_BORDER_H_
OLDNEW
« no previous file with comments | « ash/common/system/user/user_view.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698