Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4964)

Unified Diff: chrome/test/data/extensions/api_test/tabs/basics/crud2.js

Issue 2475033002: Don't show the pending URL for chrome.tabs API navigations. (Closed)
Patch Set: Identify failing test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/tabs/basics/crud2.js
diff --git a/chrome/test/data/extensions/api_test/tabs/basics/crud2.js b/chrome/test/data/extensions/api_test/tabs/basics/crud2.js
index 09fa0cb579e914f7981929e6ddb0e236854136e4..1aeb4df4769f09851d6d445824b54605ace38852 100644
--- a/chrome/test/data/extensions/api_test/tabs/basics/crud2.js
+++ b/chrome/test/data/extensions/api_test/tabs/basics/crud2.js
@@ -91,11 +91,14 @@ chrome.test.runTests([
// Update url.
chrome.tabs.update(testTabId, {"url": pageUrl("c")},
pass(function(tab){
- chrome.test.assertEq(pageUrl("c"), tab.url);
+ // TODO(creis): The tab's visible URL won't change until the navigation
+ // commits. There doesn't seem to be a way to check what the pending
+ // URL is here, so this test should wait until the navigation commits.
+ // chrome.test.assertEq(pageUrl("c"), tab.url);
// Check url.
- chrome.tabs.get(testTabId, pass(function(tab) {
- assertEq(pageUrl("c"), tab.url);
- }));
+ //chrome.tabs.get(testTabId, pass(function(tab) {
+ // assertEq(pageUrl("c"), tab.url);
+ //}));
}));
}));
},
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698