Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2475013002:
Add AndroidSpellChecker experiment for fieldtrial testing. (Closed)
|
Created:
4 years, 1 month ago by timvolodine Modified:
4 years, 1 month ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, Tobias Sargeant Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd AndroidSpellChecker experiment for fieldtrial testing.
This CL adds an "AndroidSpellChecker" experiment to the field trials
under test for the Android platform. It tests enabling spellchecking
in Chrome on Android by default on non low-end devices.
BUG=650851, 629609
Committed: https://crrev.com/821e4ef0cc2d7f7c68a538ebc6fed627f8fb802b
Cr-Commit-Position: refs/heads/master@{#429982}
Patch Set 1 #Patch Set 2 : add disable_features #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
timvolodine@chromium.org changed reviewers: + asvitkine@chromium.org
lgtm
one sec, have some comments about the server CL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
On 2016/11/03 18:26:09, Alexei Svitkine (slow) wrote: > one sec, have some comments about the server CL updated disable_features
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Add AndroidSpellChecker experiment for fieldtrial testing. This CL adds an "AndroidSpellChecker" experiment to the field trials under test for the Android platform. It tests enabling spellchecking in Chrome on Android by default on non low-end devices. BUG=650851 ========== to ========== Add AndroidSpellChecker experiment for fieldtrial testing. This CL adds an "AndroidSpellChecker" experiment to the field trials under test for the Android platform. It tests enabling spellchecking in Chrome on Android by default on non low-end devices. BUG=650851,629609 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add AndroidSpellChecker experiment for fieldtrial testing. This CL adds an "AndroidSpellChecker" experiment to the field trials under test for the Android platform. It tests enabling spellchecking in Chrome on Android by default on non low-end devices. BUG=650851,629609 ========== to ========== Add AndroidSpellChecker experiment for fieldtrial testing. This CL adds an "AndroidSpellChecker" experiment to the field trials under test for the Android platform. It tests enabling spellchecking in Chrome on Android by default on non low-end devices. BUG=650851,629609 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add AndroidSpellChecker experiment for fieldtrial testing. This CL adds an "AndroidSpellChecker" experiment to the field trials under test for the Android platform. It tests enabling spellchecking in Chrome on Android by default on non low-end devices. BUG=650851,629609 ========== to ========== Add AndroidSpellChecker experiment for fieldtrial testing. This CL adds an "AndroidSpellChecker" experiment to the field trials under test for the Android platform. It tests enabling spellchecking in Chrome on Android by default on non low-end devices. BUG=650851,629609 Committed: https://crrev.com/821e4ef0cc2d7f7c68a538ebc6fed627f8fb802b Cr-Commit-Position: refs/heads/master@{#429982} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/821e4ef0cc2d7f7c68a538ebc6fed627f8fb802b Cr-Commit-Position: refs/heads/master@{#429982} |
