Optimize ApiSignature.addBytes()

Optimize ApiSignature.addBytes()

This makes the benchmark below to run in 100 ms, vs. 250 ms.

main() {
  var bytes = new Uint8List(16);
  for (int i = 0; i < 2000; i++) {
    var timer = new Stopwatch()..start();
    ApiSignature signature = new ApiSignature();
    for (int i = 0; i < 1000; i++) {
      for (int i = 0; i < 1500; i++) {
        signature.addBytes(bytes);
      }
    }
    timer.stop();
    print('time: ${timer.elapsedMilliseconds}');
  }
}


R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e7f4816f9d037a0a57ff5b15d559c2d5e3dbb0e2

[Paul Berry, 2016-11-04 16:24:30]

lgtm

[scheglov, 2016-11-04 18:24:17]

Description was changed from

==========
Optimize ApiSignature.addBytes()

This makes the benchmark below to run in 100 ms, vs. 250 ms.

main() {
  var bytes = new Uint8List(16);
  for (int i = 0; i < 2000; i++) {
    var timer = new Stopwatch()..start();
    ApiSignature signature = new ApiSignature();
    for (int i = 0; i < 1000; i++) {
      for (int i = 0; i < 1500; i++) {
        signature.addBytes(bytes);
      }
    }
    timer.stop();
    print('time: ${timer.elapsedMilliseconds}');
  }
}


R=paulberry@google.com
BUG=
==========

to

==========
Optimize ApiSignature.addBytes()

This makes the benchmark below to run in 100 ms, vs. 250 ms.

main() {
  var bytes = new Uint8List(16);
  for (int i = 0; i < 2000; i++) {
    var timer = new Stopwatch()..start();
    ApiSignature signature = new ApiSignature();
    for (int i = 0; i < 1000; i++) {
      for (int i = 0; i < 1500; i++) {
        signature.addBytes(bytes);
      }
    }
    timer.stop();
    print('time: ${timer.elapsedMilliseconds}');
  }
}


R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e7f4816f9d037a0a57ff5b15d559c2d5e3dbb0e2
==========

[scheglov, 2016-11-04 18:24:19]

Committed patchset #1 (id:1) manually as
e7f4816f9d037a0a57ff5b15d559c2d5e3dbb0e2 (presubmit successful).