Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2474973002: Remove dead code in SkBitmapProcLegacyShader::ContextSize (Closed)

Created:
4 years, 1 month ago by sylvestre
Modified:
4 years, 1 month ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove dead code in SkBitmapProcLegacyShader::ContextSize BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2474973002 Committed: https://skia.googlesource.com/skia/+/09c85a53c370325d4e8646e34be7684728a1f375

Patch Set 1 #

Patch Set 2 : Also fix SkOpSegment::nextChase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/core/SkBitmapProcShader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sylvestre
4 years, 1 month ago (2016-11-06 21:07:07 UTC) #4
reed1
bitmapshaper part lgtm. Cary, any issues w/ pathops change?
4 years, 1 month ago (2016-11-07 15:22:14 UTC) #6
caryclark
lgtm BTW, bin/coverage does a good job of revealing dead code. It shows that the ...
4 years, 1 month ago (2016-11-07 16:02:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474973002/20001
4 years, 1 month ago (2016-11-07 17:11:11 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 17:12:08 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/09c85a53c370325d4e8646e34be7684728a1f375

Powered by Google App Engine
This is Rietveld 408576698