Add a flag to turn on incremental LTCG.

Add a flag to turn on incremental LTCG.

BUG=548454
Committed: https://crrev.com/fdfe75c61341b79acbc82db402d9e7ce84452e15
Cr-Commit-Position: refs/heads/master@{#429942}

[Sébastien Marchand, 2016-11-03 15:07:32]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 15:07:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 15:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 15:10:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sébastien Marchand, 2016-11-03 15:39:58]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 15:40:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2016-11-03 15:56:12]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 15:57:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2016-11-03 17:16:30]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Sébastien Marchand, 2016-11-03 17:16:31]

PTAL.

[brucedawson, 2016-11-03 18:13:19]

lgtm

https://codereview.chromium.org/2474963002/diff/20001/build/config/compiler/c...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2474963002/diff/20001/build/config/compiler/c...
build/config/compiler/compiler.gni:54: use_incremental_ltcg = false
One could argue that this should be named "use_incremental_wpo" for consistency
with the full_wpo_on_official flag. But, I can see a case for either name, so it
is your call.

[commit-bot: I haz the power, 2016-11-03 18:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:50:20]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2016-11-03 21:18:02]

https://codereview.chromium.org/2474963002/diff/20001/build/config/compiler/c...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2474963002/diff/20001/build/config/compiler/c...
build/config/compiler/compiler.gni:54: use_incremental_ltcg = false
On 2016/11/03 18:13:19, brucedawson wrote:
> One could argue that this should be named "use_incremental_wpo" for
consistency
> with the full_wpo_on_official flag. But, I can see a case for either name, so
it
> is your call.

tough call, I'll go with the wpo variant as these 2 flags will almost always be
used together.

[Sébastien Marchand, 2016-11-03 21:18:05]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-11-03 21:18:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2474963002/#ps40001
(title: "s/LTCG/WPO.")

[commit-bot: I haz the power, 2016-11-03 21:19:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-11-03 21:23:38]

lgtm

[commit-bot: I haz the power, 2016-11-03 22:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:58:12]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sébastien Marchand, 2016-11-04 16:35:18]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:35:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:45:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 18:17:29]

Description was changed from

==========
Add a flag to turn on incremental LTCG.

BUG=548454
==========

to

==========
Add a flag to turn on incremental LTCG.

BUG=548454

Committed: https://crrev.com/fdfe75c61341b79acbc82db402d9e7ce84452e15
Cr-Commit-Position: refs/heads/master@{#429942}
==========

[commit-bot: I haz the power, 2016-11-04 18:17:30]

Patchset 3 (id:??) landed as
https://crrev.com/fdfe75c61341b79acbc82db402d9e7ce84452e15
Cr-Commit-Position: refs/heads/master@{#429942}