chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h - Issue 2474943002: doc.write intervention warning message changed to replace cross-origin with cross site (etdl+1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

Issue 2474943002: doc.write intervention warning message changed to replace cross-origin with cross site (etdl+1) (Closed)

Patch Set: Added the histogram for same site with different scheme. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

index 0261f1d36c19094c991459707331ad842d3b2618..251647b73ee31429071a1a7fb66dfbadbb05d0bf 100644

--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

@@ -63,6 +63,7 @@ class DocumentWritePageLoadMetricsObserver

const page_load_metrics::PageLoadExtraInfo& info);

bool doc_write_block_reload_observed_;

+ bool doc_write_block_same_site_diff_scheme_;

jkarlin 2016/11/29 16:19:12 Prefer to set these two bools to false here instea

shivanisha 2016/12/06 18:18:08 Done.

DISALLOW_COPY_AND_ASSIGN(DocumentWritePageLoadMetricsObserver);

};