Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8846)

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

Issue 2474943002: doc.write intervention warning message changed to replace cross-origin with cross site (etdl+1) (Closed)
Patch Set: Added a helper function Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
index a4358a64dc36a5b68cd4718045b54dcf2f914ffa..ff534cf4a93eace8e823194dca4e89c91b169081 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
@@ -39,6 +39,13 @@ class DocumentWritePageLoadMetricsObserver
void OnLoadingBehaviorObserved(
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ enum DocumentWriteLoadingBehavior {
+ LOADING_BEHAVIOR_BLOCK,
+ LOADING_BEHAVIOR_RELOAD,
+ LOADING_BEHAVIOR_SAME_SITE_DIFF_SCHEME,
+ LOADING_BEHAVIOR_MAX
+ };
+
private:
void LogDocumentWriteEvaluatorFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
@@ -64,6 +71,7 @@ class DocumentWritePageLoadMetricsObserver
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info);
+ bool doc_write_same_site_diff_scheme_ = false;
bool doc_write_block_observed_ = false;
bool doc_write_block_reload_observed_ = false;
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698