chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h - Issue 2474943002: doc.write intervention warning message changed to replace cross-origin with cross site (etdl+1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

Issue 2474943002: doc.write intervention warning message changed to replace cross-origin with cross site (etdl+1) (Closed)

Patch Set: Bot failures fixed. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

index a4358a64dc36a5b68cd4718045b54dcf2f914ffa..4b1181c8538d1ab8d9ff8de3ce48fa07aa961657 100644

--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

@@ -64,6 +64,14 @@ class DocumentWritePageLoadMetricsObserver

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info);

+ enum DocumentWriteLoadingBehavior {

+ LOADING_BEHAVIOR_BLOCK,

+ LOADING_BEHAVIOR_RELOAD,

+ LOADING_BEHAVIOR_SAME_SITE_DIFF_SCHEME,

+ LOADING_BEHAVIOR_MAX

+ };

+ bool doc_write_same_site_diff_scheme_ = false;

bool doc_write_block_observed_ = false;

bool doc_write_block_reload_observed_ = false;