Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 247493002: Eliminate all interactive terminal prompts from git. (Closed)

Created:
6 years, 8 months ago by szager1
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Eliminate all interactive terminal prompts from git. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265735

Patch Set 1 #

Patch Set 2 : fix scm_unittest.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M gclient_scm.py View 2 chunks +4 lines, -14 lines 0 comments Download
M scm.py View 1 chunk +18 lines, -3 lines 0 comments Download
M tests/gclient_scm_test.py View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/scm_unittest.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
szager1
This will hopefully eliminate once and for all the 'gclient hangs in a subprocess waiting ...
6 years, 8 months ago (2014-04-22 14:33:31 UTC) #1
ghost stip (do not use)
lgtm
6 years, 8 months ago (2014-04-22 18:12:14 UTC) #2
szager1
The CQ bit was checked by szager@chromium.org
6 years, 8 months ago (2014-04-22 19:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/247493002/1
6 years, 8 months ago (2014-04-22 19:02:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 19:04:06 UTC) #5
commit-bot: I haz the power
Presubmit check for 247493002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-22 19:04:07 UTC) #6
ghost stip (do not use)
you just have to add the export to that dang unittest
6 years, 8 months ago (2014-04-23 18:13:38 UTC) #7
szager1
The CQ bit was checked by szager@chromium.org
6 years, 8 months ago (2014-04-23 20:56:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/247493002/20001
6 years, 8 months ago (2014-04-23 20:56:57 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 20:59:24 UTC) #10
Message was sent while issue was closed.
Change committed as 265735

Powered by Google App Engine
This is Rietveld 408576698