Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc

Issue 2474923002: Fix race in MediaDevicesPermissionChecker. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
diff --git a/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc b/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
index 658d47b892ed3af485a2d4d55134eebbc0bbdd03..f2cecbc183e94e56838cf6b92f8c477ccae05535 100644
--- a/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
+++ b/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
@@ -13,6 +13,7 @@
#include "base/bind.h"
#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/browser/renderer_host/media/media_stream_manager.h"
@@ -96,9 +97,8 @@ class MediaDevicesDispatcherHostTest : public testing::Test {
bool enumerate_video_input,
bool enumerate_audio_output,
bool permission_override_value = true) {
- MediaDevicesPermissionChecker permission_checker;
- permission_checker.OverridePermissionsForTesting(permission_override_value);
- host_->SetPermissionChecker(permission_checker);
+ host_->SetPermissionChecker(base::MakeUnique<MediaDevicesPermissionChecker>(
+ permission_override_value));
base::RunLoop run_loop;
host_->EnumerateDevices(
enumerate_audio_input, enumerate_video_input, enumerate_audio_output,

Powered by Google App Engine
This is Rietveld 408576698