Tablet-like power button behavior on Convertible/Tablet ChromeOS devices

ash/shell.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELL_H_
 #define ASH_SHELL_H_
 
 #include <memory>
 #include <utility>
 #include <vector>
@@ skipping 99 matching lines @@
 class ScreenPositionController;
 class SessionStateDelegate;
 class ShellDelegate;
 struct ShellInitParams;
 class SlowAnimationEventFilter;
 class StatusAreaWidget;
 class StickyKeysController;
 class SystemGestureEventFilter;
 class SystemModalContainerEventFilter;
 class SystemTray;
+class TabletPowerButtonController;

[Daniel Erat, 2016/11/11 05:40:50]

nit: this should probably be in an ifdef too

[Qiang(Joe) Xu, 2016/11/11 18:19:30]

done by removing

 class ToplevelWindowEventHandler;
 class TouchTransformerController;
 class TouchObserverHUD;
 class ScreenLayoutObserver;
 class VirtualKeyboardController;
 class VideoActivityNotifier;
 class VideoDetector;
 class WebNotificationTray;
 class WindowPositioner;
 class WindowTreeHostManager;
@@ skipping 141 matching lines @@
   }
   TouchTransformerController* touch_transformer_controller() {
     return touch_transformer_controller_.get();
   }
   LaserPointerController* laser_pointer_controller() {
     return laser_pointer_controller_.get();
   }
   PartialMagnificationController* partial_magnification_controller() {
     return partial_magnification_controller_.get();
   }
+  TabletPowerButtonController* tablet_power_button_controller() {
+    return tablet_power_button_controller_.get();
+  }
 #endif  // defined(OS_CHROMEOS)
   ScreenshotController* screenshot_controller() {
     return screenshot_controller_.get();
   }
   MouseCursorEventFilter* mouse_cursor_filter() {
     return mouse_cursor_filter_.get();
   }
   EventTransformationHandler* event_transformation_handler() {
     return event_transformation_handler_.get();
   }
@@ skipping 231 matching lines @@
   std::unique_ptr<ScreenOrientationController> screen_orientation_controller_;
   std::unique_ptr<ScreenLayoutObserver> screen_layout_observer_;
 
   std::unique_ptr<TouchTransformerController> touch_transformer_controller_;
 
   std::unique_ptr<ui::EventHandler> magnifier_key_scroll_handler_;
   std::unique_ptr<ui::EventHandler> speech_feedback_handler_;
   std::unique_ptr<LaserPointerController> laser_pointer_controller_;
   std::unique_ptr<PartialMagnificationController>
       partial_magnification_controller_;
+  std::unique_ptr<TabletPowerButtonController> tablet_power_button_controller_;

[Daniel Erat, 2016/11/11 05:40:50]

you can probably avoid moving this to ash::Shell by just adding a
tablet_power_button_controller_for_test() accessor to PowerButtonController,
right?

[Qiang(Joe) Xu, 2016/11/11 18:19:30]

Done.

 #endif  // defined(OS_CHROMEOS)
 
   // |native_cursor_manager_| is owned by |cursor_manager_|, but we keep a
   // pointer to vend to test code.
   AshNativeCursorManager* native_cursor_manager_;
 
   // Cursor may be hidden on certain key events in ChromeOS, whereas we never
   // hide the cursor on Windows.
   std::unique_ptr<::wm::CursorManager> cursor_manager_;
 
   // For testing only: simulate that a modal window is open
   bool simulate_modal_window_open_for_testing_;
 
   bool is_touch_hud_projection_enabled_;
 
   // Injected content::GPUDataManager support.
   std::unique_ptr<GPUSupport> gpu_support_;
 
   std::unique_ptr<ImmersiveHandlerFactoryAsh> immersive_handler_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Shell);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELL_H_