Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2474873003: [turbofan] Tune the ValueNumberingReducer's growth rate (Closed)

Created:
4 years, 1 month ago by Leszek Swirski
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Tune the ValueNumberingReducer's growth rate Changes the ValueNumberingReducer to grow when at 80% capacity, rather than at 50% capacity. This matches the behaviour of base/hashmap. Committed: https://crrev.com/a902ef88a39b6fde2774522486191ce0f8ba37ea Cr-Commit-Position: refs/heads/master@{#40734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/compiler/value-numbering-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/value-numbering-reducer.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Leszek Swirski
Hey Benedikt, I'm seeing a reasonable performance boost locally from this change, on most of ...
4 years, 1 month ago (2016-11-03 14:08:07 UTC) #6
Benedikt Meurer
Nice, LGTM.
4 years, 1 month ago (2016-11-03 16:11:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474873003/1
4 years, 1 month ago (2016-11-03 16:13:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 16:14:45 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:21:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a902ef88a39b6fde2774522486191ce0f8ba37ea
Cr-Commit-Position: refs/heads/master@{#40734}

Powered by Google App Engine
This is Rietveld 408576698