Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2474863003: Disable DisplayItemClientTest.IsAlive under UBSan. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable DisplayItemClientTest.IsAlive under UBSan. This test makes a virtual call on a bad pointer, and UBSan is rightfully not happy about it. BUG=607996 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/56c5f7e3a885b62cc821f1847a80f1652a70da2f Cr-Commit-Position: refs/heads/master@{#429779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClientTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
krasin1
4 years, 1 month ago (2016-11-04 03:20:48 UTC) #5
haraken
LGTM
4 years, 1 month ago (2016-11-04 04:15:26 UTC) #6
krasin1
On 2016/11/04 04:15:26, haraken wrote: > LGTM Thank you, Kentaro!
4 years, 1 month ago (2016-11-04 04:19:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474863003/1
4 years, 1 month ago (2016-11-04 04:20:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 04:29:17 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 04:31:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56c5f7e3a885b62cc821f1847a80f1652a70da2f
Cr-Commit-Position: refs/heads/master@{#429779}

Powered by Google App Engine
This is Rietveld 408576698