Add inspector tests to default tests to run locally.

Add inspector tests to default tests to run locally.

R=machenbach@chromium.org

Committed: https://crrev.com/c20f27a25460584dee1b4684acdb7cd6c608d525
Cr-Commit-Position: refs/heads/master@{#40751}

[Michael Achenbach, 2016-11-03 08:22:17]

https://codereview.chromium.org/2474863002/diff/1/test/default.isolate
File test/default.isolate (right):

https://codereview.chromium.org/2474863002/diff/1/test/default.isolate#newcode14
test/default.isolate:14: 'inspector/inspector.isolate'
Also needs a line here:
https://cs.chromium.org/chromium/src/v8/test/default.gyp?l=19

and move this up to default tests:
https://cs.chromium.org/chromium/src/v8/test/BUILD.gn?l=63

https://codereview.chromium.org/2474863002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2474863002/diff/1/tools/run-tests.py#newcode62
tools/run-tests.py:62: # Map of test name synonyms to lists of test suites.
Should be ordered by
Please no alpha sort, see this comment. Inspector should go somewhere below
webkit as it's a bit faster then most webkit test, but e.g. not as fast as
unittests.

[Michael Achenbach, 2016-11-03 08:23:40]

https://codereview.chromium.org/2474863002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2474863002/diff/1/tools/run-tests.py#newcode69
tools/run-tests.py:69: "debugger",
If debugger isn't dog slow, it should also be moved a bit lower.

[Yang, 2016-11-03 08:33:27]

addressed comments.

https://codereview.chromium.org/2474863002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2474863002/diff/1/tools/run-tests.py#newcode62
tools/run-tests.py:62: # Map of test name synonyms to lists of test suites.
Should be ordered by
On 2016/11/03 08:22:17, machenbach (slow) wrote:
> Please no alpha sort, see this comment. Inspector should go somewhere below
> webkit as it's a bit faster then most webkit test, but e.g. not as fast as
> unittests.

I see. I reordered this a bit.

[Michael Achenbach, 2016-11-03 08:53:52]

lgtm with comment:

https://codereview.chromium.org/2474863002/diff/20001/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2474863002/diff/20001/tools/run-tests.py#newc...
tools/run-tests.py:615: TEST_MAP["bot_default"].remove("inspector")
Please also add a line here:
TEST_MAP["default"].remove("inspector")

[Yang, 2016-11-03 09:09:57]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-03 09:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2474863002/#ps40001
(title: "remove on non inspector builds")

[commit-bot: I haz the power, 2016-11-03 09:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 09:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 09:13:18]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Yang, 2016-11-03 09:27:00]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-03 09:27:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2474863002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-11-03 09:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 09:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 09:31:18]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Yang, 2016-11-03 09:34:52]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 09:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 09:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 09:55:26]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-11-03 10:25:31]

https://codereview.chromium.org/2474863002/diff/80001/test/default.gyp
File test/default.gyp (right):

https://codereview.chromium.org/2474863002/diff/80001/test/default.gyp#newcode23
test/default.gyp:23: 'dependencies': [
IC, we didn't even include this yet as the gyp bots have it off. But formally
this is correct now to potentially allow turning it on on gyp too.

[Michael Achenbach, 2016-11-03 10:25:59]

Please remove alphasort comment from CL desc.

[Yang, 2016-11-04 08:47:12]

Description was changed from

==========
Add inspector tests to default tests to run locally.

Also, alphasort.

R=machenbach@chromium.org
==========

to

==========
Add inspector tests to default tests to run locally.

R=machenbach@chromium.org
==========

[Yang, 2016-11-04 08:48:10]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-04 08:48:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2474863002/#ps80001
(title: "fix?")

[commit-bot: I haz the power, 2016-11-04 08:48:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 08:50:01]

Description was changed from

==========
Add inspector tests to default tests to run locally.

R=machenbach@chromium.org
==========

to

==========
Add inspector tests to default tests to run locally.

R=machenbach@chromium.org
==========

[commit-bot: I haz the power, 2016-11-04 08:50:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 22:22:03]

Description was changed from

==========
Add inspector tests to default tests to run locally.

R=machenbach@chromium.org
==========

to

==========
Add inspector tests to default tests to run locally.

R=machenbach@chromium.org

Committed: https://crrev.com/c20f27a25460584dee1b4684acdb7cd6c608d525
Cr-Commit-Position: refs/heads/master@{#40751}
==========

[commit-bot: I haz the power, 2016-11-17 22:22:04]

Patchset 5 (id:??) landed as
https://crrev.com/c20f27a25460584dee1b4684acdb7cd6c608d525
Cr-Commit-Position: refs/heads/master@{#40751}