src/objects.cc - Issue 2474843003: Allow the global object to be frozen through the global template

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2474843003: Allow the global object to be frozen through the global template (Closed)

Patch Set: Refactor to keep all template logic in api Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 4c72b3e932aaeb55a94041b51762e209c2a3eb61..65186b8baa0be3d4287508b7fa3385839d80e9d2 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -15553,7 +15553,7 @@ Maybe<bool> JSObject::SetPrototype(Handle<JSObject> object,

// Nothing to do if prototype is already set.

if (map->prototype() == *value) return Just(true);

- bool immutable_proto = object->map()->is_immutable_proto();

+ bool immutable_proto = map->is_immutable_proto();

if (immutable_proto) {

RETURN_FAILURE(

isolate, should_throw,