Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 247483002: Allow touch events to be uncancelable (Closed)

Created:
6 years, 8 months ago by Rick Byers
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, eae+blinkwatch, ojan, jdduke (slow)
Visibility:
Public.

Description

Allow touch events to be uncancelable The touchevents specification says (http://www.w3.org/TR/touch-events/#list-of-touchevent-types) that touchcancel events should not be cancelable. We'd also like to allow other touch events (touchmove and touchend) to sometimes be uncancelable (sent async) as well, so rather than special-case touchcancel here we plumb a bit from the browser. This leaves the decision over which events are cancelable purely in the hands of the browser (except for edge cases around synthetic events), which makes sense because only the browser can know whether it plans to wait for an ACK for the event before proceeding with gesture recognition. Note that I can't properly test this in a layout test without changing EventSender in the chromium repo, but I can't change EventSender until WebTouchEvent has changed. So there's no avoiding a 3-sided patch here. Once the first 2 CLs have landed I'll land a new LayoutTest before marking bug 365681 as Fixed. BUG=365681, 361306 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172329

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Fix build on some platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M Source/core/events/TouchEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/TouchEvent.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PlatformTouchEvent.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/web/WebInputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M public/web/WebInputEvent.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Rick Byers
Adam, please take a look (this is that change related to touchmove absorption that we ...
6 years, 8 months ago (2014-04-22 18:16:12 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-22 20:40:41 UTC) #2
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 8 months ago (2014-04-22 20:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/247483002/30001
6 years, 8 months ago (2014-04-22 20:46:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 21:57:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-22 21:57:11 UTC) #6
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 8 months ago (2014-04-23 00:11:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/247483002/30001
6 years, 8 months ago (2014-04-23 00:12:18 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 07:15:12 UTC) #9
Message was sent while issue was closed.
Change committed as 172329

Powered by Google App Engine
This is Rietveld 408576698