[Media Remoting] Add function to create interstitial.

media/base/media_resources.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_MEDIA_RESOURCES_H_
 #define MEDIA_BASE_MEDIA_RESOURCES_H_
 
 #include <string>
 
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 #include "media/base/media_export.h"
 
 namespace media {
 
 // The media layer can't access Chrome's resource bundle directly. This facility
 // allows clients to provide indirect access.
 
 // IDs that will get mapped to corresponding entries with IDS_ prefixes in
 // chrome/app/generated_resources.grd.
 enum MessageId {
   DEFAULT_AUDIO_DEVICE_NAME,
 #if defined(OS_WIN)
   COMMUNICATIONS_AUDIO_DEVICE_NAME,
 #endif
 #if defined(OS_CHROMEOS)
   BEAMFORMING_ON_DEFAULT_AUDIO_INPUT_DEVICE_NAME,
   BEAMFORMING_OFF_DEFAULT_AUDIO_INPUT_DEVICE_NAME,
 #endif
+  MEDIA_REMOTING_CAST_ERROR_TEXT,

[xjz, 2016/11/03 23:53:39]

ditto: add build flag here.

[apacible, 2016/11/04 01:25:38]

Done.

+  MEDIA_REMOTING_CASTING_VIDEO_TEXT,
 };
 
 // Implementations are expected to convert MessageIds to generated_resources.grd
 // IDs and extract the matching string from Chrome's resource bundle (e.g.
 // through l10n_util::GetStringUTF16).
 using LocalizedStringProvider = base::string16 (*)(MessageId message_id);
 
 // Initializes the global LocalizedStringProvider function.
 MEDIA_EXPORT void SetLocalizedStringProvider(LocalizedStringProvider func);

[xjz, 2016/11/03 23:53:39]

Do we need MEDIA_EXPORT here?

[apacible, 2016/11/04 01:25:38]

Yes.

[xjz, 2016/11/04 22:10:23]

I think only component needs export. right? Also, even if export is needed, I
don't think we are allowed to use MEDIA_EXPORT, as this is not in the media
target.

[apacible, 2016/11/05 01:12:51]

Ack.

 
 #if !defined(OS_IOS)
 // The LocalizedStringProvider has probably not been initialized on iOS. This
 // will give an early compile warning for clients attempting to use it.
 
 // Returns a resource string corresponding to |message_id|. See l10n_util.h.
 // Returns an empty string if the LocalizedStringProvider has not been
 // initialized or if the ID is unrecognized.
-std::string GetLocalizedStringUTF8(MessageId message_id);
+MEDIA_EXPORT std::string GetLocalizedStringUTF8(MessageId message_id);

[xjz, 2016/11/03 23:53:39]

ditto: MEDIA_EXPORT

[apacible, 2016/11/04 01:25:38]

Yes, we need MEDIA_EXPORT to use the function.

[xjz, 2016/11/04 22:10:23]

ditto.

[apacible, 2016/11/05 01:12:51]

Removed MEDIA_EXPORT.

 base::string16 GetLocalizedStringUTF16(MessageId message_id);
 #endif
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MEDIA_RESOURCES_H_