Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/constrained_window/constrained_window_views.cc

Issue 2474783002: Fix memory leak for extension uninstall dialog. (Closed)
Patch Set: Address Oshima's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc ('K') | « chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/constrained_window/constrained_window_views.cc
diff --git a/components/constrained_window/constrained_window_views.cc b/components/constrained_window/constrained_window_views.cc
index ccdfdd1606700fa05b4f4d4cfdd5ab52e98489c2..a1ea2a216675e5e6fbfb2dd4f6e487d7b428161a 100644
--- a/components/constrained_window/constrained_window_views.cc
+++ b/components/constrained_window/constrained_window_views.cc
@@ -60,7 +60,7 @@ class WidgetModalDialogHostObserverViews
}
// WidgetObserver overrides
- void OnWidgetClosing(views::Widget* widget) override { delete this; }
+ void OnWidgetDestroying(views::Widget* widget) override { delete this; }
// WebContentsModalDialogHostObserver overrides
void OnPositionRequiresUpdate() override {
« chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc ('K') | « chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698