third_party/WebKit/Source/core/events/PromiseRejectionEvent.h - Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/PromiseRejectionEvent.h

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)

Patch Set: Addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/PromiseRejectionEvent.h

diff --git a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.h b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.h

index e3170b4b2daa586dcfb32c44ed44f1aaee417967..b3933c372225b2ed40fb33e5c8e5beea1e491003 100644

--- a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.h

+++ b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.h

@@ -51,8 +51,8 @@ class CORE_EXPORT PromiseRejectionEvent final : public Event {

void dispose();

RefPtr<ScriptState> m_scriptState;

- ScopedPersistent<v8::Value> m_promise;

- ScopedPersistent<v8::Value> m_reason;

+ TraceWrapperScopedPersistent<v8::Value> m_promise;

+ TraceWrapperScopedPersistent<v8::Value> m_reason;

};

} // namespace blink