third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl - Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)

Patch Set: Addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h ('K') | « third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl ('k') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

index fd90cbf9c25e6a1204d37ce233c94055db07f319..1318dba63ce6c560f5567705a617aed4427a012f 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

@@ -42,7 +42,7 @@ class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_c

{{cpp_class}}(ScriptState*, v8::Local<v8::Function>);

RefPtr<ScriptState> m_scriptState;

- ScopedPersistent<v8::Function> m_callback;

+ TraceWrapperScopedPersistent<v8::Function> m_callback;

};

} // namespace blink