Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)
Patch Set: Added bailout for tests when the flag is off Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/EventTarget.cpp
diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp
index a21200c0c9aeaf182adc17b47bb7e9bca96c90ce..bf5009de7b46e88c1ba45e3c181be43731e6a241 100644
--- a/third_party/WebKit/Source/core/events/EventTarget.cpp
+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp
@@ -158,12 +158,7 @@ DEFINE_TRACE_WRAPPERS(EventTarget) {
while (EventListener* listener = iterator.nextListener()) {
if (listener->type() != EventListener::JSEventListenerType)
continue;
- V8AbstractEventListener* v8listener =
- static_cast<V8AbstractEventListener*>(listener);
- if (!v8listener->hasExistingListenerObject())
- continue;
-
- visitor->traceWrappers(v8listener);
+ visitor->traceWrappers(static_cast<V8AbstractEventListener*>(listener));
}
}
@@ -305,10 +300,8 @@ bool EventTarget::addEventListenerInternal(
eventType, listener, options, &registeredListener);
if (added) {
if (listener->type() == EventListener::JSEventListenerType) {
- V8AbstractEventListener* v8listener =
- static_cast<V8AbstractEventListener*>(listener);
- if (v8listener->hasExistingListenerObject())
- ScriptWrappableVisitor::writeBarrier(this, v8listener);
+ ScriptWrappableVisitor::writeBarrier(
+ this, static_cast<V8AbstractEventListener*>(listener));
}
addedEventListener(eventType, registeredListener);
}

Powered by Google App Engine
This is Rietveld 408576698