Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)
Patch Set: Added bailout for tests when the flag is off Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
index bfacdca9dc57632ad120a31a4f9819c671395426..a3f6c61008dc39c0324ead44023437d785bcd842 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
@@ -20,7 +20,7 @@ namespace blink {
VoidCallbackFunctionInterfaceArg::VoidCallbackFunctionInterfaceArg(ScriptState* scriptState, v8::Local<v8::Function> callback)
: m_scriptState(scriptState),
- m_callback(scriptState->isolate(), callback) {
+ m_callback(scriptState->isolate(), this, callback) {
DCHECK(!m_callback.isEmpty());
m_callback.setPhantom();
}
@@ -28,7 +28,7 @@ VoidCallbackFunctionInterfaceArg::VoidCallbackFunctionInterfaceArg(ScriptState*
DEFINE_TRACE(VoidCallbackFunctionInterfaceArg) {}
DEFINE_TRACE_WRAPPERS(VoidCallbackFunctionInterfaceArg) {
- visitor->traceWrappers(&m_callback.cast<v8::Object>());
+ visitor->traceWrappers(m_callback.cast<v8::Value>());
}
bool VoidCallbackFunctionInterfaceArg::call(ScriptWrappable* scriptWrappable, HTMLDivElement* divElement) {

Powered by Google App Engine
This is Rietveld 408576698