Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)
Patch Set: Added bailout for tests when the flag is off Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
index 005ff1cd9c7fa7c7ffc3181c1ffdf1ffb90d2850..7e5519c60893e6182988e505fa7366af0b05cf55 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
@@ -19,7 +19,7 @@ namespace blink {
LongCallbackFunction::LongCallbackFunction(ScriptState* scriptState, v8::Local<v8::Function> callback)
: m_scriptState(scriptState),
- m_callback(scriptState->isolate(), callback) {
+ m_callback(scriptState->isolate(), this, callback) {
DCHECK(!m_callback.isEmpty());
m_callback.setPhantom();
}
@@ -27,7 +27,7 @@ LongCallbackFunction::LongCallbackFunction(ScriptState* scriptState, v8::Local<v
DEFINE_TRACE(LongCallbackFunction) {}
DEFINE_TRACE_WRAPPERS(LongCallbackFunction) {
- visitor->traceWrappers(&m_callback.cast<v8::Object>());
+ visitor->traceWrappers(m_callback.cast<v8::Value>());
}
bool LongCallbackFunction::call(ScriptWrappable* scriptWrappable, int num1, int num2, int& returnValue) {

Powered by Google App Engine
This is Rietveld 408576698