third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl - Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)

Patch Set: Added bailout for tests when the flag is off Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp ('k') | third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

index e73d99f406765bd1276a38300513dca04d3c30d9..8fe5cfcdf5a0317e461eee17483d05b2f8ad723e 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

@@ -13,7 +13,7 @@ namespace blink {

{{cpp_class}}::{{cpp_class}}(ScriptState* scriptState, v8::Local<v8::Function> callback)

: m_scriptState(scriptState),

- m_callback(scriptState->isolate(), callback) {

+ m_callback(scriptState->isolate(), this, callback) {

DCHECK(!m_callback.isEmpty());

m_callback.setPhantom();

}

@@ -21,7 +21,7 @@ namespace blink {

DEFINE_TRACE({{cpp_class}}) {}

DEFINE_TRACE_WRAPPERS({{cpp_class}}) {

- visitor->traceWrappers(&m_callback.cast<v8::Object>());

+ visitor->traceWrappers(m_callback.cast<v8::Value>());

}

bool {{cpp_class}}::call({{argument_declarations | join(', ')}}) {