Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)
Patch Set: Added bailout for tests when the flag is off Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
index 82a6d73e9c431cc7d6bf916e06120677e6f05d3a..df9c67781156ed567eea6a2909c2b36b89ff2d8b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
@@ -6,6 +6,7 @@
#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/DOMWrapperWorld.h"
+#include "bindings/core/v8/ScopedPersistent.h"
#include "bindings/core/v8/ScriptWrappableVisitorVerifier.h"
#include "bindings/core/v8/V8AbstractEventListener.h"
#include "bindings/core/v8/WrapperTypeInfo.h"
@@ -211,16 +212,30 @@ void ScriptWrappableVisitor::markWrappersInAllWorlds(
const_cast<ScriptWrappable*>(scriptWrappable), this, m_reporter);
}
-void ScriptWrappableVisitor::traceWrappers(
- const ScopedPersistent<v8::Value>* scopedPersistent) const {
- markWrapper(
- &(const_cast<ScopedPersistent<v8::Value>*>(scopedPersistent)->get()));
+void ScriptWrappableVisitor::writeBarrier(
+ const void* srcObject,
+ const TraceWrapperV8Reference<v8::Value>* dstObject) {
+ if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {
+ return;
+ }
+ if (!srcObject || !dstObject || dstObject->isEmpty()) {
+ return;
+ }
+ // We only require a write barrier if |srcObject| is already marked. Note
+ // that this implicitly disables the write barrier when the GC is not
+ // active as object will not be marked in this case.
+ if (!HeapObjectHeader::fromPayload(srcObject)->isWrapperHeaderMarked()) {
+ return;
+ }
+ currentVisitor(ThreadState::current()->isolate())
+ ->markWrapper(
+ &(const_cast<TraceWrapperV8Reference<v8::Value>*>(dstObject)->get()));
}
void ScriptWrappableVisitor::traceWrappers(
- const ScopedPersistent<v8::Object>* scopedPersistent) const {
+ const TraceWrapperV8Reference<v8::Value>& tracedWrapper) const {
markWrapper(
- &(const_cast<ScopedPersistent<v8::Object>*>(scopedPersistent)->get()));
+ &(const_cast<TraceWrapperV8Reference<v8::Value>&>(tracedWrapper).get()));
}
void ScriptWrappableVisitor::markWrapper(
@@ -229,12 +244,6 @@ void ScriptWrappableVisitor::markWrapper(
handle->RegisterExternalReference(m_reporter);
}
-void ScriptWrappableVisitor::markWrapper(
- const v8::PersistentBase<v8::Object>* handle) const {
- DCHECK(m_reporter);
- handle->RegisterExternalReference(m_reporter);
-}
-
void ScriptWrappableVisitor::dispatchTraceWrappers(
const TraceWrapperBase* wrapperBase) const {
wrapperBase->traceWrappers(this);

Powered by Google App Engine
This is Rietveld 408576698