third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 2474693002: [wrapper-tracing] Support for incrementally tracing ScopedPersistent (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h ('k') | third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

index c4b135f9dbc4e8ec87f1900ff0eab4b7625521fe..712aeb127920b2a7b586986bfef29dad8c52431e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -46,6 +46,7 @@ V8AbstractEventListener::V8AbstractEventListener(bool isAttribute,

DOMWrapperWorld& world,

v8::Isolate* isolate)

: EventListener(JSEventListenerType),

+ m_listener(nullptr),

m_isAttribute(isAttribute),

m_world(world),

m_isolate(isolate),

@@ -226,7 +227,7 @@ DEFINE_TRACE(V8AbstractEventListener) {

}

DEFINE_TRACE_WRAPPERS(V8AbstractEventListener) {

- visitor->traceWrappers(&m_listener);

+ visitor->traceWrappers(&m_listener.cast<v8::Value>());

}

} // namespace blink