Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2474673002: Replace references to MediaStreamTrack.getSources() with enumerateDevices() in PPAPI. (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
Reviewers:
bbudge
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, piman+watch_chromium.org, feature-media-reviews_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, chromium-apps-reviews_chromium.org, ihf+watch_chromium.org, hta - Chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace references to MediaStreamTrack.getSources() with enumerateDevices() in PPAPI. MediaStreamTrack.getSources is scheduled for removal in M56. BUG=388194 Committed: https://crrev.com/8730a9894cd009bd19833b04d85d5dad2dd7f2e5 Cr-Commit-Position: refs/heads/master@{#429361}

Patch Set 1 : remove non ppapi files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ppapi/api/private/ppb_camera_device_private.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/private/ppb_camera_device_private.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/cpp/private/camera_device_private.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
Guido Urdaneta
bbudge@chromium.org: please review changes in ppapi/ (the change is only in comments)
4 years, 1 month ago (2016-11-02 16:32:17 UTC) #9
bbudge
lgtm
4 years, 1 month ago (2016-11-02 17:39:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474673002/40001
4 years, 1 month ago (2016-11-02 17:40:22 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-11-02 19:20:55 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 19:24:35 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8730a9894cd009bd19833b04d85d5dad2dd7f2e5
Cr-Commit-Position: refs/heads/master@{#429361}

Powered by Google App Engine
This is Rietveld 408576698