Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/prefs/preferences_manager.cc

Issue 2474653003: PreferencesManager (Closed)
Patch Set: Update PreferencesManager to account for base::Value API change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/preferences_manager.h ('k') | chrome/browser/prefs/preferences_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/preferences_manager.cc
diff --git a/chrome/browser/prefs/preferences_manager.cc b/chrome/browser/prefs/preferences_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d3fe49d1461a1be0ac7a63e3bbf8351272a5a60d
--- /dev/null
+++ b/chrome/browser/prefs/preferences_manager.cc
@@ -0,0 +1,89 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/prefs/preferences_manager.h"
+
+#include "base/auto_reset.h"
+#include "base/bind.h"
+#include "base/values.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/prefs/pref_change_registrar.h"
+#include "components/prefs/pref_service.h"
+
+PreferencesManager::PreferencesManager(Profile* profile)
+ : preferences_change_registrar_(new PrefChangeRegistrar),
+ setting_preferences_(false) {
+ DCHECK(profile);
+ service_ = profile->GetPrefs();
+ preferences_change_registrar_->Init(service_);
+}
+
+PreferencesManager::~PreferencesManager() {}
+
+void PreferencesManager::PreferenceChanged(const std::string& preference_name) {
+ if (setting_preferences_)
+ return;
+ const PrefService::Preference* pref =
+ service_->FindPreference(preference_name);
+ std::unique_ptr<base::DictionaryValue> dictionary =
+ base::MakeUnique<base::DictionaryValue>();
+ dictionary->Set(preference_name, pref->GetValue()->CreateDeepCopy());
+ client_->OnPreferencesChanged(std::move(dictionary));
+}
+
+void PreferencesManager::AddObserver(
+ prefs::mojom::PreferencesObserverPtr client) {
+ // TODO(jonross): once service_manager::Connector supports enforcing two-way
+ // binding at connection time, update PreferencesManager to use that approach.
+ // After which enforcing bind checks will not be needed (crbug.com/674140)
+ client_ = std::move(client);
+}
+
+void PreferencesManager::SetPreferences(
+ std::unique_ptr<base::DictionaryValue> preferences) {
+ if (!client_.is_bound())
+ return;
+ DCHECK(!setting_preferences_);
+ // We ignore preference changes caused by us.
+ base::AutoReset<bool> setting_preferences(&setting_preferences_, true);
+ for (base::DictionaryValue::Iterator it(*preferences); !it.IsAtEnd();
+ it.Advance()) {
+ if (!preferences_change_registrar_->IsObserved(it.key()))
+ continue;
+ const PrefService::Preference* pref = service_->FindPreference(it.key());
+ if (!pref) {
+ DLOG(ERROR) << "Preference " << it.key() << " not found.\n";
+ continue;
+ }
+ if (it.value().Equals(pref->GetValue()))
+ continue;
+ service_->Set(it.key(), it.value());
+ }
+}
+
+void PreferencesManager::Subscribe(
+ const std::vector<std::string>& preferences) {
+ if (!client_.is_bound())
+ return;
+ std::unique_ptr<base::DictionaryValue> dictionary =
+ base::MakeUnique<base::DictionaryValue>();
+ for (auto& it : preferences) {
+ const PrefService::Preference* pref = service_->FindPreference(it);
+ if (!pref) {
+ DLOG(ERROR) << "Preference " << it << " not found.\n";
+ continue;
+ }
+ // PreferenceManager lifetime is managed by a mojo::StrongBindingPtr owned
+ // by PreferenceConnectionManager. It will outlive
+ // |preferences_change_registrar_| which it owns.
+ preferences_change_registrar_->Add(
+ it, base::Bind(&PreferencesManager::PreferenceChanged,
+ base::Unretained(this)));
+ dictionary->Set(it, pref->GetValue()->CreateDeepCopy());
+ }
+
+ if (dictionary->empty())
+ return;
+ client_->OnPreferencesChanged(std::move(dictionary));
+}
« no previous file with comments | « chrome/browser/prefs/preferences_manager.h ('k') | chrome/browser/prefs/preferences_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698