PreferencesManager

chrome/browser/prefs/preferences_connection_manager.cc

Index: chrome/browser/prefs/preferences_connection_manager.cc
diff --git a/chrome/browser/prefs/preferences_connection_manager.cc b/chrome/browser/prefs/preferences_connection_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ea7f0a8ee1a755f6243d63c78e90dc50fe0223a3
--- /dev/null
+++ b/chrome/browser/prefs/preferences_connection_manager.cc
@@ -0,0 +1,83 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/prefs/preferences_connection_manager.h"
+
+#include "chrome/browser/prefs/preferences_manager.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "components/keyed_service/content/browser_context_keyed_service_shutdown_notifier_factory.h"
+
+namespace {
+
+// Required singleton subclass to control dependencies between
+// PreferenceConnectionManager and the KeyedServiceShutdownNotifier.
+class ShutdownNotifierFactory
+    : public BrowserContextKeyedServiceShutdownNotifierFactory {
+ public:
+  static ShutdownNotifierFactory* GetInstance() {
+    return base::Singleton<ShutdownNotifierFactory>::get();
+  }
+
+ private:
+  friend struct base::DefaultSingletonTraits<ShutdownNotifierFactory>;
+
+  ShutdownNotifierFactory()
+      : BrowserContextKeyedServiceShutdownNotifierFactory(
+            "PreferencesConnectionManager") {
+    DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
+  }
+  ~ShutdownNotifierFactory() override {}
+
+  DISALLOW_COPY_AND_ASSIGN(ShutdownNotifierFactory);
+};
+
+}  // namespace
+
+PreferencesConnectionManager::PreferencesConnectionManager()
+    : profile_shutdown_notification_(
+          ShutdownNotifierFactory::GetInstance()
+              ->Get(ProfileManager::GetActiveUserProfile())
+              ->Subscribe(
+                  base::Bind(&PreferencesConnectionManager::OnProfileDestroyed,
+                             base::Unretained(this)))) {}
+
+PreferencesConnectionManager::~PreferencesConnectionManager() {}
+
+void PreferencesConnectionManager::ProcessRequest(
+    prefs::mojom::PreferencesManagerRequest request) {
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  mojo::StrongBindingPtr<prefs::mojom::PreferencesManager> binding =
+      mojo::MakeStrongBinding(base::MakeUnique<PreferencesManager>(profile),
+                              std::move(request));
+  // Copying the base::WeakPtr for future deletion.
+  binding->set_connection_error_handler(
+      base::Bind(&PreferencesConnectionManager::OnConnectionError,
+                 base::Unretained(this), binding));
+  bindings_.push_back(std::move(binding));
+}
+
+void PreferencesConnectionManager::OnConnectionError(
+    mojo::StrongBindingPtr<prefs::mojom::PreferencesManager> binding) {
+  if (!binding)
+    return;
+  auto it = std::begin(bindings_);
+  while (it != std::end(bindings_)) {

[dcheng, 2016/12/15 16:17:08]

I don't think the iterator is advanced here (it's probably more common to write
this as a for loop, but I don't feel strongly about that)

[jonross, 2016/12/19 15:58:13]

Done.

+    if (it->get() == binding.get()) {
+      bindings_.erase(it);
+      return;
+    }
+  }
+}
+
+void PreferencesConnectionManager::OnProfileDestroyed() {
+  for (auto& it : bindings_) {
+    // Shutdown any PreferenceManager that is still alive.
+    if (it)
+      it->Close();
+  }
+
+  profile_shutdown_notification_.reset();
+}