PreferencesManager

services/preferences/public/interfaces/preferences.mojom

Index: services/preferences/public/interfaces/preferences.mojom
diff --git a/services/preferences/public/interfaces/preferences.mojom b/services/preferences/public/interfaces/preferences.mojom
index bf8d186bfea59db06e7f86cfb37a073846e2c366..0ff39765a8276c9efb8ba562a25b5bee692d2546 100644
--- a/services/preferences/public/interfaces/preferences.mojom
+++ b/services/preferences/public/interfaces/preferences.mojom
@@ -6,6 +6,8 @@ module prefs.mojom;
 
 import "mojo/common/common_custom_types.mojom";
 
+const string kServiceName = "prefs:manager";

[sadrul, 2016/12/08 01:07:22]

This is kCapabilityName, right?

[jonross, 2016/12/08 14:36:40]

I'd only seen kServiceName used in mojoms for declaring services/capabilities

[sadrul, 2016/12/08 15:33:31]

service name is the actual name of the service you use to connect to the thing,
e.g. "ui" or "catalog". In this case, 'prefs:manager' is not the name of the
service, it's the name of the capability you use in your manifest, right? I
think kCapabilityName would be a better name to clarify that. Are there other
places where we use 'service name' to refer to capability?

[jonross, 2016/12/09 20:48:03]

There currently is 0 usage of kCapabilityName. Though it does make sense to
differentiate between the two styles of connection.

[jonross, 2016/12/14 15:01:41]

Done.

+
 // Used to subscribe to preference changes within PreferenceManager. After
 // requesting to observe, the current values for all requested keys are sent.
 interface PreferencesObserver {
@@ -15,6 +17,7 @@ interface PreferencesObserver {
 // Manages actual read/write of preference data. Accepts observers who subscribe
 // to preferences, notifying them of changes.
 interface PreferencesManager {
-  AddObserver(array<string> preferences, PreferencesObserver client);
+  AddObserver(PreferencesObserver client);
   SetPreferences(mojo.common.mojom.DictionaryValue preferences);
+  Subscribe(array<string> preferences);
 };