PreferencesManager

chrome/browser/prefs/preferences_connection_manager.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PREFERENCES_CONNECTION_MANAGER_H_
+#define CHROME_BROWSER_PREFS_PREFERENCES_CONNECTION_MANAGER_H_
+
+#include <vector>
+
+#include "base/macros.h"
+#include "components/keyed_service/core/keyed_service_shutdown_notifier.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "services/preferences/public/interfaces/preferences.mojom.h"
+
+namespace chrome {

[sky, 2016/12/06 23:37:37]

I wouldn't put this in any namespace (see threads in chromium-dev on
namespaces).

[jonross, 2016/12/07 15:46:39]

I had missed those threads. Removed the namespace.

+
+// Handles all incoming prefs::mojom::PreferenceManagerRequest, providing a
+// separate PreferencesManager per connection request.
+//
+// Additionally monitors system shutdown to clean up connections to PrefService.
+//
+// TODO(jonross): Observe profile switching and update PreferenceManager
+// connections.
+class PreferencesConnectionManager {

[sky, 2016/12/06 23:37:37]

Is the plan that this class is used from places other than chromeos? If not, or
if there aren't any near term plans I suggest moving to chromeos.

[jonross, 2016/12/07 00:31:28]

This would come down to the timing of a few things
  - mus enabled on non-chromeos
  - the full preferences services being its own process
  - non-ash processes interested in preferences from chrome

If we only need to support ash and chromeos until the preferences service is
separated, then this can be moved into the chromeos dir

[sky, 2016/12/07 18:05:16]

If long term we're going to go with this, then leave it here.

+ public:
+  PreferencesConnectionManager();
+  ~PreferencesConnectionManager();
+
+  // Creates a new PreferencesManager and binds it to |request|.
+  void ProcessRequest(prefs::mojom::PreferencesManagerRequest request);
+
+ private:
+  // KeyedServiceShutdownNotifier::Subscription callback. Used to cleanup when
+  // the active PrefService is being destroyed.
+  void OnProfileDestroyed();
+
+  // Bindings that automatically cleanup during connection errors.
+  std::vector<mojo::StrongBindingPtr<prefs::mojom::PreferencesManager>>
+      bindings_;
+
+  // Observes shutdown, when PrefService is being destroyed.
+  std::unique_ptr<KeyedServiceShutdownNotifier::Subscription>
+      profile_shutdown_notification_;
+
+  DISALLOW_COPY_AND_ASSIGN(PreferencesConnectionManager);
+};
+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_PREFS_PREFERENCES_CONNECTION_MANAGER_H_