PreferencesManager

ash/common/shelf/shelf_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SHELF_SHELF_CONTROLLER_H_
 #define ASH_COMMON_SHELF_SHELF_CONTROLLER_H_
 
 #include <map>
 #include <string>
 
 #include "ash/common/shelf/shelf_item_types.h"
 #include "ash/common/shelf/shelf_model.h"
 #include "ash/public/cpp/shelf_types.h"
 #include "ash/public/interfaces/shelf.mojom.h"
+#include "components/prefs/pref_store.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 #include "mojo/public/cpp/bindings/interface_ptr_set.h"
+#include "services/preferences/public/cpp/pref_observer_store.h"
 
 namespace ash {
 
 class WmShelf;
 
 // Ash's implementation of the mojom::ShelfController interface. Chrome connects
 // to this interface to observe and manage the per-display ash shelf instances.
-class ShelfController : public mojom::ShelfController {
+class ShelfController : public mojom::ShelfController,
+                        public PrefStore::Observer {
  public:
   ShelfController();
   ~ShelfController() override;
 
   // Binds the mojom::ShelfController interface request to this object.
   void BindRequest(mojom::ShelfControllerRequest request);
 
   ShelfModel* model() { return &model_; }
 
   const std::map<std::string, ShelfID>& app_id_to_shelf_id() {
@@ skipping 12 matching lines @@
   // mojom::Shelf:
   void AddObserver(mojom::ShelfObserverAssociatedPtrInfo observer) override;
   void SetAlignment(ShelfAlignment alignment, int64_t display_id) override;
   void SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide,
                            int64_t display_id) override;
   void PinItem(mojom::ShelfItemPtr item,
                mojom::ShelfItemDelegateAssociatedPtrInfo delegate) override;
   void UnpinItem(const std::string& app_id) override;
   void SetItemImage(const std::string& app_id, const SkBitmap& image) override;
 
+  // PrefStore::Observer:
+  void OnPrefValueChanged(const std::string& key) override;
+  void OnInitializationCompleted(bool succeeded) override;
+
  private:
   // The shelf model shared by all shelf instances.
   ShelfModel model_;
 
   // Bindings for the ShelfController interface.
   mojo::BindingSet<mojom::ShelfController> bindings_;
 
   // The set of shelf observers notified about shelf state and settings changes.
   mojo::AssociatedInterfacePtrSet<mojom::ShelfObserver> observers_;
 
+  scoped_refptr<PrefObserverStore> store_;

[James Cook, 2016/11/18 00:50:34]

Like we discussed in person, I think a single centralized store would be nice.

(That might also reduce the #include burden. Mojo headers are really heavy, and
pref_observer_store.h includes some mojo stuff.)

[jonross, 2016/11/18 20:31:23]

Yeah I agree. I will update this example in a bit with a unified one in WmShell

+
   // Mappings between application and shelf ids.
   std::map<std::string, ShelfID> app_id_to_shelf_id_;
   std::map<ShelfID, std::string> shelf_id_to_app_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfController);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SHELF_SHELF_CONTROLLER_H_