Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2474653002: Revert of [ic] Experiment: disable map-specific handler cache. (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ic] Experiment: disable map-specific handler cache. (patchset #1 id:1 of https://codereview.chromium.org/2462973003/ ) Reason for revert: Causes performance regressions (up to 10% on the "IC" bucket). :-( Original issue's description: > [ic] Experiment: disable map-specific handler cache. > > IC data handlers support most of the hot cases nowdays. Let's see if > the map-specific code cache still help us to improve things. > > BUG=v8:5561 TBR=ishell@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5561 Committed: https://crrev.com/5ce976067254ff971237bc2daf46b91b7d364d51 Cr-Commit-Position: refs/heads/master@{#40701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/ic/handler-compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-code-cache.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jakob Kummerow
Created Revert of [ic] Experiment: disable map-specific handler cache.
4 years, 1 month ago (2016-11-02 13:23:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474653002/1
4 years, 1 month ago (2016-11-02 13:23:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 13:49:32 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ce976067254ff971237bc2daf46b91b7d364d51
Cr-Commit-Position: refs/heads/master@{#40701}

Powered by Google App Engine
This is Rietveld 408576698