Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2474603002: Don't include LayoutObject-derived headers where not needed. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni, Xianzhu, aboxhall
CC:
chromium-reviews, szager+layoutwatch_chromium.org, nektar+watch_chromium.org, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, Srirama, rwlbuis, aboxhall, aboxhall+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, Navid Zolghadr, blink-reviews, kenneth.christiansen, nessy, zoltan1, blink-reviews-layout_chromium.org, sof, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, darktears, haraken, vcarbune.chromium, dtapuska+blinkwatch_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, blink-reviews-paint_chromium.org, nektarios, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include LayoutObject-derived headers where not needed. Or, if a LayoutObject-derived header is still required, pick the most generic one possible. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/8990614c565f4158ee1e0109fb48f1575760b877 Cr-Commit-Position: refs/heads/master@{#430165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -49 lines) Patch
M third_party/WebKit/Source/core/css/DragUpdateTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMeterElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentainerIterator.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/observer/ResizeObserverEntry.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerUtil.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 13 chunks +24 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
mstensho (USE GERRIT)
aboxhall for modules/accessibility/ wangxianzhu for the rest :) This is the third and final CL ...
4 years, 1 month ago (2016-11-02 09:17:42 UTC) #3
mstensho (USE GERRIT)
On 2016/11/02 09:17:42, mstensho wrote: > aboxhall for modules/accessibility/ > wangxianzhu for the rest :) ...
4 years, 1 month ago (2016-11-02 09:49:17 UTC) #4
Xianzhu
lgtm
4 years, 1 month ago (2016-11-02 15:37:27 UTC) #5
mstensho (USE GERRIT)
@aboxhall ping
4 years, 1 month ago (2016-11-04 20:29:39 UTC) #6
dmazzoni
lgtm for modules/accessibility In the future please feel free to TBR accessibility owners for refactoring ...
4 years, 1 month ago (2016-11-04 22:22:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474603002/1
4 years, 1 month ago (2016-11-05 12:15:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 13:52:37 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 13:55:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8990614c565f4158ee1e0109fb48f1575760b877
Cr-Commit-Position: refs/heads/master@{#430165}

Powered by Google App Engine
This is Rietveld 408576698