Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: tracing/tracing/value/chart_json_converter_test.html

Issue 2474573002: Convert chart-json to Histograms. (Closed)
Patch Set: test with tir label Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/chart_json_converter_test.html
diff --git a/tracing/tracing/value/chart_json_converter_test.html b/tracing/tracing/value/chart_json_converter_test.html
new file mode 100644
index 0000000000000000000000000000000000000000..4692e55862542eb94ce8a1cb9edc60d8e8f19a21
--- /dev/null
+++ b/tracing/tracing/value/chart_json_converter_test.html
@@ -0,0 +1,56 @@
+<!DOCTYPE html>
+<!--
+Copyright 2016 The Chromium Authors. All rights reserved.
+Use of this source code is governed by a BSD-style license that can be
+found in the LICENSE file.
+-->
+
+<link rel="import" href="/tracing/value/chart_json_converter.html">
+<link rel="import" href="/tracing/value/histogram_set.html">
+
+<script>
+'use strict';
+
+tr.b.unittest.testSuite(function() {
+ test('convertWithoutTIRLabel', function() {
+ // TODO
+ });
+
+ test('convertWithTIRLabel', function() {
+ var charts = {
+ 'charts': {
+ 'TIR-A@@value-name': {
+ 'story-name': {
+ 'name': 'value-name',
+ 'page_id': 7,
+ 'improvement_direction': 'down',
+ 'values': [42],
+ 'units': 'ms',
+ 'tir_label': 'TIR-A',
+ 'type': 'list_of_scalar_values',
+ },
+ 'summary': {
+ 'name': 'value-name',
+ 'improvement_direction': 'down',
+ 'values': [42],
+ 'units': 'ms',
+ 'tir_label': 'TIR-A',
+ 'type': 'list_of_scalar_values',
+ },
+ },
+ },
+ };
+ var histograms = new tr.v.HistogramSet();
+ tr.v.ChartJsonConverter.convertChartJson(charts, histograms);
+ assert.lengthOf(histograms, 1);
+ var hist = [...histograms][0];
+ assert.strictEqual('value-name', hist.name);
+ assert.strictEqual('TIR-A',
+ tr.v.HistogramSet.GROUPINGS.LEGACY_TIR_LABEL.callback(hist));
+ assert.strictEqual(42, hist.average);
+ assert.strictEqual(1, hist.numValues);
+ assert.strictEqual(tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,
+ hist.unit);
+ });
+});
+</script>

Powered by Google App Engine
This is Rietveld 408576698