Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: telemetry/telemetry/internal/results/html2_output_formatter.py

Issue 2474573002: Convert chart-json to Histograms. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/results/html2_output_formatter.py
diff --git a/telemetry/telemetry/internal/results/html2_output_formatter.py b/telemetry/telemetry/internal/results/html2_output_formatter.py
index 7935265d30cc8548d9bac32ba87632ff7b50ef9d..11bbb96f9099c4ba4175c965de348afed67c5d03 100644
--- a/telemetry/telemetry/internal/results/html2_output_formatter.py
+++ b/telemetry/telemetry/internal/results/html2_output_formatter.py
@@ -8,22 +8,28 @@ import os
from py_utils import cloud_storage
+from telemetry.internal.results import chart_json_output_formatter
from telemetry.internal.results import output_formatter
from tracing import results_renderer
class Html2OutputFormatter(output_formatter.OutputFormatter):
- _JSON_TAG = '<div id="value-set-json">%s</div>'
-
- def __init__(self, output_stream, reset_results, upload_results):
+ def __init__(self, output_stream, metadata, reset_results, upload_results):
super(Html2OutputFormatter, self).__init__(output_stream)
+ self._metadata = metadata
self._upload_results = upload_results
self._reset_results = reset_results
def Format(self, page_test_results):
- results_renderer.RenderHTMLView(page_test_results.value_set,
- self._output_stream, self._reset_results)
+ chart_json = []
+ histograms = page_test_results.value_set
+ if not histograms:
+ chart_json.append(chart_json_output_formatter.ResultsAsChartDict(
+ self._metadata, page_test_results.all_page_specific_values,
+ page_test_results.all_summary_values))
+ results_renderer.RenderHTMLView(histograms, chart_json,
+ self._output_stream, self._reset_results)
file_path = os.path.abspath(self._output_stream.name)
if self._upload_results:
remote_path = ('html-results/results-%s' %
« no previous file with comments | « no previous file | telemetry/telemetry/internal/results/html_output_formatter.py » ('j') | tracing/bin/chartjson2histograms » ('J')

Powered by Google App Engine
This is Rietveld 408576698