DevTools: isolate settings of custom devtoools front-end.

DevTools: isolate settings of custom devtoools front-end.

Currently, changing a setting inside custom devtools front-end (the one
served through chrome-devtools://devtools/custom) will change the same
setting inside bundled devtools.

This is unfortunate. In the setup we aim for, the custom devtools
are inspected by the bundled devtools, and we want them to be
independent of each other.

This patch starts using local storage for the settings of the
chrome-devtools://devtools/custom front-end.

Note: settings will be isolated, whereas experiments won't.

BUG=629914
R=dgozman

Committed: https://crrev.com/16056dbccd68723d61feaf6e9a9518a300485c2c
Cr-Commit-Position: refs/heads/master@{#429414}

[lushnikov, 2016-11-02 04:01:05]

please, take a look

[lushnikov, 2016-11-02 04:01:10]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 04:01:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 05:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 05:32:26]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-02 17:31:57]

https://codereview.chromium.org/2474563002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2474563002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:65: * @return
{boolean}
I'd suggest to return InspectorFrontendHostAPI from here (either real or stub)
and use it's methods consistently.

[lushnikov, 2016-11-02 18:49:00]

how would you like the new approach?

https://codereview.chromium.org/2474563002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2474563002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:65: * @return
{boolean}
On 2016/11/02 17:31:57, dgozman wrote:
> I'd suggest to return InspectorFrontendHostAPI from here (either real or stub)
> and use it's methods consistently.

Done.

[lushnikov, 2016-11-02 18:49:04]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 18:49:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-11-02 19:47:58]

lgtm

https://codereview.chromium.org/2474563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2474563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:89: prefs,
preferencesProvider.setPreference, preferencesProvider.removePreference,
Don't you have to bind here?

[lushnikov, 2016-11-02 20:01:00]

https://codereview.chromium.org/2474563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2474563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:89: prefs,
preferencesProvider.setPreference, preferencesProvider.removePreference,
On 2016/11/02 19:47:58, dgozman wrote:
> Don't you have to bind here?

It's not required, but let's bind to be on the safe side

[lushnikov, 2016-11-02 20:01:04]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-02 20:01:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2474563002/#ps40001
(title: "bind")

[commit-bot: I haz the power, 2016-11-02 20:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 21:57:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-02 21:59:17]

Description was changed from

==========
DevTools: isolate settings of custom devtoools front-end.

Currently, changing a setting inside custom devtools front-end (the one
served through chrome-devtools://devtools/custom) will change the same
setting inside bundled devtools.

This is unfortunate. In the setup we aim for, the custom devtools
are inspected by the bundled devtools, and we want them to be
independent of each other.

This patch starts using local storage for the settings of the
chrome-devtools://devtools/custom front-end.

Note: settings will be isolated, whereas experiments won't.

BUG=629914
R=dgozman
==========

to

==========
DevTools: isolate settings of custom devtoools front-end.

Currently, changing a setting inside custom devtools front-end (the one
served through chrome-devtools://devtools/custom) will change the same
setting inside bundled devtools.

This is unfortunate. In the setup we aim for, the custom devtools
are inspected by the bundled devtools, and we want them to be
independent of each other.

This patch starts using local storage for the settings of the
chrome-devtools://devtools/custom front-end.

Note: settings will be isolated, whereas experiments won't.

BUG=629914
R=dgozman

Committed: https://crrev.com/16056dbccd68723d61feaf6e9a9518a300485c2c
Cr-Commit-Position: refs/heads/master@{#429414}
==========

[commit-bot: I haz the power, 2016-11-02 21:59:19]

Patchset 3 (id:??) landed as
https://crrev.com/16056dbccd68723d61feaf6e9a9518a300485c2c
Cr-Commit-Position: refs/heads/master@{#429414}

[lushnikov, 2016-11-08 23:52:20]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2483333003/ by lushnikov@chromium.org.

The reason for reverting is: Reverting this patchset since it doesn't fully
address problem. LocalStorage settings still clash..