Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: pkg/dev_compiler/web/web_command.dart

Issue 2474523003: fix #27607, add dev_compiler summary to the SDK and move JS files (Closed)
Patch Set: fix typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/build_test_pkgs.sh ('k') | tools/create_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/web/web_command.dart
diff --git a/pkg/dev_compiler/web/web_command.dart b/pkg/dev_compiler/web/web_command.dart
index 68b216a7ddb01eb71f9c96ac9432e6d73ec33653..bc4c1ad3d2dddeb1a9a38d682b8da0e3c18fd0a6 100644
--- a/pkg/dev_compiler/web/web_command.dart
+++ b/pkg/dev_compiler/web/web_command.dart
@@ -197,11 +197,13 @@ class WebCompileCommand extends Command {
JSModuleFile module = compiler.compile(unit, compilerOptions);
- var moduleCode = module.isValid
- ? module
- .getCode(ModuleFormat.legacy, true, unit.name, unit.name + '.map')
- .code
- : '';
+ var moduleCode = '';
+ if (module.isValid) {
+ moduleCode = module
+ .getCode(ModuleFormat.legacy, unit.name, unit.name + '.map',
+ singleOutFile: true)
+ .code;
+ }
return new CompileResult(
code: moduleCode, isValid: module.isValid, errors: module.errors);
« no previous file with comments | « pkg/dev_compiler/tool/build_test_pkgs.sh ('k') | tools/create_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698