Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: pkg/dev_compiler/lib/src/compiler/command.dart

Issue 2474523003: fix #27607, add dev_compiler summary to the SDK and move JS files (Closed)
Patch Set: fix typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/src/analyzer/context.dart ('k') | pkg/dev_compiler/lib/src/compiler/compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/command.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/command.dart b/pkg/dev_compiler/lib/src/compiler/command.dart
index a51cf88d62118b3450404a0f81e5af6bab4ae577..d97ae111330bab1d35d7068c763e86604580a137 100644
--- a/pkg/dev_compiler/lib/src/compiler/command.dart
+++ b/pkg/dev_compiler/lib/src/compiler/command.dart
@@ -154,11 +154,17 @@ void _compile(ArgResults argResults, void printFn(Object obj)) {
// Write JS file, as well as source map and summary (if requested).
for (var i = 0; i < outPaths.length; i++) {
- var outPath = outPaths[i];
- module.writeCodeSync(moduleFormats[i], singleOutFile, outPath);
- if (module.summaryBytes != null) {
- var summaryPath =
- path.withoutExtension(outPath) + '.${compilerOpts.summaryExtension}';
+ module.writeCodeSync(moduleFormats[i], outPaths[i],
+ singleOutFile: singleOutFile);
+ }
+ if (module.summaryBytes != null) {
+ var summaryPaths = compilerOpts.summaryOutPath != null
+ ? [compilerOpts.summaryOutPath]
+ : outPaths.map((p) =>
+ '${path.withoutExtension(p)}.${compilerOpts.summaryExtension}');
+
+ // place next to every compiled module
+ for (var summaryPath in summaryPaths) {
// Only overwrite if summary changed. This plays better with timestamp
// based build systems.
var file = new File(summaryPath);
« no previous file with comments | « pkg/dev_compiler/lib/src/analyzer/context.dart ('k') | pkg/dev_compiler/lib/src/compiler/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698