Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2474493002: [Merge M-55] Float card scanner icon at the end of EditText instead of compound drawable (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge M-55] Float card scanner icon at the end of EditText instead of compound drawable This gives better user experience since compound drawable do not support click event. BUG=657178, 640430 Review-Url: https://codereview.chromium.org/2434383002 Cr-Commit-Position: refs/heads/master@{#427222} (cherry picked from commit c3da4b51497fca50ebed5e4adbec3f7ada68ceda) Committed: https://chromium.googlesource.com/chromium/src/+/ce76404e0039ea48174770ecfc09e356aed8bd1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -16 lines) Patch
M chrome/android/java/res/layout/payments_request_editor_textview.xml View 1 chunk +25 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java View 6 chunks +56 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 1 month ago (2016-11-01 22:04:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce76404e0039ea48174770ecfc09e356aed8bd1b.

Powered by Google App Engine
This is Rietveld 408576698