Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: src/inspector/v8-heap-profiler-agent-impl.h

Issue 2474483003: [inspector] migrate HeapProfiler to new style (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-heap-profiler-agent-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-heap-profiler-agent-impl.h
diff --git a/src/inspector/v8-heap-profiler-agent-impl.h b/src/inspector/v8-heap-profiler-agent-impl.h
index caa969870bacc5e438629c70dd7ac98dcb5de276..e0e244715f07a3fae55c41a2a20b3ecb298676e5 100644
--- a/src/inspector/v8-heap-profiler-agent-impl.h
+++ b/src/inspector/v8-heap-profiler-agent-impl.h
@@ -15,8 +15,8 @@ namespace v8_inspector {
class V8InspectorSessionImpl;
-using protocol::ErrorString;
using protocol::Maybe;
+using protocol::Response;
class V8HeapProfilerAgentImpl : public protocol::HeapProfiler::Backend {
public:
@@ -25,32 +25,26 @@ class V8HeapProfilerAgentImpl : public protocol::HeapProfiler::Backend {
~V8HeapProfilerAgentImpl() override;
void restore();
- void collectGarbage(ErrorString*) override;
+ Response collectGarbage() override;
- void enable(ErrorString*) override;
- void startTrackingHeapObjects(ErrorString*,
- const Maybe<bool>& trackAllocations) override;
- void stopTrackingHeapObjects(ErrorString*,
- const Maybe<bool>& reportProgress) override;
+ Response enable() override;
+ Response startTrackingHeapObjects(Maybe<bool> trackAllocations) override;
+ Response stopTrackingHeapObjects(Maybe<bool> reportProgress) override;
- void disable(ErrorString*) override;
+ Response disable() override;
- void takeHeapSnapshot(ErrorString*,
- const Maybe<bool>& reportProgress) override;
+ Response takeHeapSnapshot(Maybe<bool> reportProgress) override;
- void getObjectByHeapObjectId(
- ErrorString*, const String16& heapSnapshotObjectId,
- const Maybe<String16>& objectGroup,
+ Response getObjectByHeapObjectId(
+ const String16& heapSnapshotObjectId, Maybe<String16> objectGroup,
std::unique_ptr<protocol::Runtime::RemoteObject>* result) override;
- void addInspectedHeapObject(ErrorString*,
- const String16& inspectedHeapObjectId) override;
- void getHeapObjectId(ErrorString*, const String16& objectId,
- String16* heapSnapshotObjectId) override;
-
- void startSampling(ErrorString*,
- const Maybe<double>& samplingInterval) override;
- void stopSampling(
- ErrorString*,
+ Response addInspectedHeapObject(
+ const String16& inspectedHeapObjectId) override;
+ Response getHeapObjectId(const String16& objectId,
+ String16* heapSnapshotObjectId) override;
+
+ Response startSampling(Maybe<double> samplingInterval) override;
+ Response stopSampling(
std::unique_ptr<protocol::HeapProfiler::SamplingHeapProfile>*) override;
private:
« no previous file with comments | « no previous file | src/inspector/v8-heap-profiler-agent-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698