Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2474463002: Fix GradientShaderBase4fContext::Interval fuzzer assert (Closed)

Created:
4 years, 1 month ago by f(malita)
Modified:
4 years, 1 month ago
Reviewers:
Brian Osman, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GradientShaderBase4fContext::Interval fuzzer assert Although the iterator ensures v0 != v1, 2 - v0 may still be equal to 2 - v1 for very small values due to limited float precision. We need to recheck the inequality to avoid triggering Interval asserts. BUG=skia:5903 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2474463002 Committed: https://skia.googlesource.com/skia/+/cc34176c040c9703e351af7268dfc3a8b3cbf71d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/effects/gradients/Sk4fGradientBase.cpp View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
f(malita)
4 years, 1 month ago (2016-11-01 20:59:13 UTC) #2
f(malita)
4 years, 1 month ago (2016-11-02 19:19:25 UTC) #9
Brian Osman
lgtm
4 years, 1 month ago (2016-11-02 20:00:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474463002/1
4 years, 1 month ago (2016-11-02 20:09:56 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:10:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cc34176c040c9703e351af7268dfc3a8b3cbf71d

Powered by Google App Engine
This is Rietveld 408576698