Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2474433007: headless: Fix ErrorReporter unit tests (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Fix ErrorReporter unit tests Update the ErrorReporter unit tests to account for the fact that error reporting only happens when DCHECK is enabled. BUG=612904 Committed: https://crrev.com/b6696ef81450d0b54095b12c43dcd23cca89983a Cr-Commit-Position: refs/heads/master@{#429553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M headless/public/domains/types_unittest.cc View 7 chunks +14 lines, -0 lines 0 comments Download
M headless/public/util/error_reporter_unittest.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 1 month ago (2016-11-03 12:55:45 UTC) #3
altimin
lgtm
4 years, 1 month ago (2016-11-03 12:57:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474433007/1
4 years, 1 month ago (2016-11-03 13:09:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 13:17:47 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:19:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6696ef81450d0b54095b12c43dcd23cca89983a
Cr-Commit-Position: refs/heads/master@{#429553}

Powered by Google App Engine
This is Rietveld 408576698