Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2474423002: perf: Remove Facebook from power.gpu_rasterization.top_10 (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Remove Facebook from power.gpu_rasterization.top_10 Facebook sometimes never becomes network quiescent, making this test very flaky. BUG=662381 TBR=alexclarke@chromium.org Committed: https://crrev.com/03c2a6ced335de44aed77272c9c8484fb543bad6 Cr-Commit-Position: refs/heads/master@{#429894}

Patch Set 1 #

Patch Set 2 : Also fix power.top_10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M tools/perf/benchmarks/power.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_10.py View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Sami
4 years, 1 month ago (2016-11-04 12:57:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474423002/20001
4 years, 1 month ago (2016-11-04 13:04:55 UTC) #12
alex clarke (OOO till 29th)
lgtm
4 years, 1 month ago (2016-11-04 14:32:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on ...
4 years, 1 month ago (2016-11-04 15:00:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474423002/20001
4 years, 1 month ago (2016-11-04 15:23:34 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 15:31:17 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 15:34:50 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03c2a6ced335de44aed77272c9c8484fb543bad6
Cr-Commit-Position: refs/heads/master@{#429894}

Powered by Google App Engine
This is Rietveld 408576698