Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Issue 2474413002: isolate.pydeps: whitelist libs to make the check pass on trybots (Closed)

Created:
4 years, 1 month ago by Paweł Hajdan Jr.
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

isolate.pydeps: whitelist libs to make the check pass on trybots Note: more investigation may be needed. This is mostly intended to fix the bots, not necessarily the final fix. R=tandrii TBR=jochen BUG=662258 Committed: https://crrev.com/cdb3463e6d06b3f367f64f33ba56c4ea00e7b7ea Cr-Commit-Position: refs/heads/master@{#429862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/secondary/tools/swarming_client/isolate.pydeps View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
tandrii(chromium)
LGTM
4 years, 1 month ago (2016-11-04 11:36:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474413002/1
4 years, 1 month ago (2016-11-04 11:38:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 11:46:26 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdb3463e6d06b3f367f64f33ba56c4ea00e7b7ea Cr-Commit-Position: refs/heads/master@{#429862}
4 years, 1 month ago (2016-11-04 11:50:14 UTC) #13
Paweł Hajdan Jr.
4 years, 1 month ago (2016-11-04 12:38:40 UTC) #15
Message was sent while issue was closed.
TBR

Powered by Google App Engine
This is Rietveld 408576698