Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 24744002: Pattern match on generated code to find edge counters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated review comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_x64.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 365c8074b2b0e7be1de221989064002c057e2acf..50c4930838a38795c4f28430b821ce0e61609d78 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -1664,6 +1664,12 @@ void JoinEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
LocationSummary* TargetEntryInstr::MakeLocationSummary() const {
+ // FlowGraphCompiler::EmitInstructionPrologue is not called for block
+ // entry instructions, so this function is unused. If it becomes
+ // reachable, note that the deoptimization descriptor in unoptimized code
+ // comes after the point of local register allocation due to pattern
+ // matching the edge counter code backwards (as a code reuse convenience
+ // on some platforms).
UNREACHABLE();
return NULL;
}
« no previous file with comments | « runtime/vm/instructions_x64.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698