Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 24744002: Pattern match on generated code to find edge counters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated review comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc
index c07fefbfd8eed7b3cb93e9f782a4fe5868e81d03..fded60aac2b12042e47e7632e4bf629c9582dbbf 100644
--- a/runtime/vm/flow_graph_compiler_arm.cc
+++ b/runtime/vm/flow_graph_compiler_arm.cc
@@ -720,28 +720,6 @@ void FlowGraphCompiler::GenerateAssertAssignable(intptr_t token_pos,
}
-void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {
- if (!is_optimizing()) {
- if (FLAG_enable_type_checks && instr->IsAssertAssignable()) {
- AssertAssignableInstr* assert = instr->AsAssertAssignable();
- AddCurrentDescriptor(PcDescriptors::kDeopt,
- assert->deopt_id(),
- assert->token_pos());
- } else if (instr->IsGuardField() ||
- instr->CanBecomeDeoptimizationTarget()) {
- AddCurrentDescriptor(PcDescriptors::kDeopt,
- instr->deopt_id(),
- Scanner::kDummyTokenIndex);
- }
- AllocateRegistersLocally(instr);
- } else if (instr->MayThrow() &&
- (CurrentTryIndex() != CatchClauseNode::kInvalidTryIndex)) {
- // Optimized try-block: Sync locals to fixed stack locations.
- EmitTrySync(instr, CurrentTryIndex());
- }
-}
-
-
void FlowGraphCompiler::EmitTrySyncMove(intptr_t dest_offset,
Location loc,
bool* push_emitted) {
@@ -1275,6 +1253,22 @@ void FlowGraphCompiler::GenerateCallRuntime(intptr_t token_pos,
}
+void FlowGraphCompiler::EmitEdgeCounter() {
+ // We do not check for overflow when incrementing the edge counter. The
+ // function should normally be optimized long before the counter can
+ // overflow; and though we do not reset the counters when we optimize or
+ // deoptimize, there is a bound on the number of
+ // optimization/deoptimization cycles we will attempt.
+ const Array& counter = Array::ZoneHandle(Array::New(1, Heap::kOld));
+ counter.SetAt(0, Smi::Handle(Smi::New(0)));
+ __ Comment("Edge counter");
+ __ LoadObject(R0, counter);
+ __ ldr(IP, FieldAddress(R0, Array::element_offset(0)));
+ __ adds(IP, IP, ShifterOperand(Smi::RawValue(1)));
+ __ str(IP, FieldAddress(R0, Array::element_offset(0)));
+}
+
+
void FlowGraphCompiler::EmitOptimizedInstanceCall(
ExternalLabel* target_label,
const ICData& ic_data,
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698