Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: src/parsing/preparser.cc

Issue 2474393003: [parser] Give preparser and parser independent loggers (Closed)
Patch Set: The function scope is used by the preparser, so we don't need to set flags again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/preparser.cc
diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc
index 1ddda66b4e2037409af95aeeda141896b8e01a6c..62db4ef69892d7d6691223f586f0a870b792e83e 100644
--- a/src/parsing/preparser.cc
+++ b/src/parsing/preparser.cc
@@ -85,11 +85,9 @@ PreParserIdentifier PreParser::GetSymbol() const {
PreParser::PreParseResult PreParser::PreParseFunction(
FunctionKind kind, DeclarationScope* function_scope, bool parsing_module,
- SingletonLogger* log, bool is_inner_function, bool may_abort,
- int* use_counts) {
+ bool is_inner_function, bool may_abort, int* use_counts) {
DCHECK_EQ(FUNCTION_SCOPE, function_scope->scope_type());
parsing_module_ = parsing_module;
- log_ = log;
use_counts_ = use_counts;
DCHECK(!track_unresolved_variables_);
track_unresolved_variables_ = is_inner_function;
@@ -136,7 +134,7 @@ PreParser::PreParseResult PreParser::PreParseFunction(
} else if (stack_overflow()) {
return kPreParseStackOverflow;
} else if (!*ok) {
- DCHECK(log->has_error());
+ DCHECK(log_.has_error());
} else {
DCHECK_EQ(Token::RBRACE, scanner()->peek());
@@ -247,11 +245,11 @@ PreParser::LazyParsingResult PreParser::ParseStatementListAndLogFunction(
int body_end = scanner()->peek_location().end_pos;
DeclarationScope* scope = this->scope()->AsDeclarationScope();
DCHECK(scope->is_function_scope());
- log_->LogFunction(start_position, body_end, formals->num_parameters(),
- formals->function_length, has_duplicate_parameters,
- function_state_->materialized_literal_count(),
- function_state_->expected_property_count(), language_mode(),
- scope->uses_super_property(), scope->calls_eval());
+ log_.LogFunction(start_position, body_end, formals->num_parameters(),
+ formals->function_length, has_duplicate_parameters,
+ function_state_->materialized_literal_count(),
+ function_state_->expected_property_count(), language_mode(),
+ scope->uses_super_property(), scope->calls_eval());
return kLazyParsingComplete;
}

Powered by Google App Engine
This is Rietveld 408576698