MacViews/a11y: Accessibility actions use AXActionData in AXPlatformNodeDelegate.

ui/accessibility/platform/ax_platform_node_mac.mm

Index: ui/accessibility/platform/ax_platform_node_mac.mm
diff --git a/ui/accessibility/platform/ax_platform_node_mac.mm b/ui/accessibility/platform/ax_platform_node_mac.mm
index a30b42007f0140a42d8e60c9fce9f014b3031ff2..f3f5f117125e484d8316626f48a9ff1a7a0186fd 100644
--- a/ui/accessibility/platform/ax_platform_node_mac.mm
+++ b/ui/accessibility/platform/ax_platform_node_mac.mm
@@ -9,6 +9,7 @@
 
 #include "base/macros.h"
 #include "base/strings/sys_string_conversions.h"
+#include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/accessibility/platform/ax_platform_node_delegate.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
@@ -379,7 +380,8 @@ void NotifyMacEvent(AXPlatformNodeCocoa* target, ui::AXEvent event_type) {
 
   if ([attributeName isEqualToString:NSAccessibilityValueAttribute] ||
       [attributeName isEqualToString:NSAccessibilitySelectedTextAttribute])
-    return node_->GetDelegate()->CanSetStringValue();
+    return !ui::AXNodeData::IsFlagSet(node_->GetData().state,
+                                      ui::AX_STATE_READ_ONLY);
 
   if ([attributeName isEqualToString:NSAccessibilityFocusedAttribute]) {
     return ui::AXNodeData::IsFlagSet(node_->GetData().state,
@@ -392,20 +394,22 @@ void NotifyMacEvent(AXPlatformNodeCocoa* target, ui::AXEvent event_type) {
 }
 
 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute {
+  ui::AXActionData data;
   if ([value isKindOfClass:[NSString class]]) {
+    data.value = base::SysNSStringToUTF16(value);
     if ([attribute isEqualToString:NSAccessibilityValueAttribute]) {
-      node_->GetDelegate()->SetStringValue(base::SysNSStringToUTF16(value),
-                                           true);
+      data.action = ui::AX_ACTION_SET_VALUE;
     } else if ([attribute
                    isEqualToString:NSAccessibilitySelectedTextAttribute]) {
-      node_->GetDelegate()->SetStringValue(base::SysNSStringToUTF16(value),
-                                           false);
+      data.action = ui::AX_ACTION_REPLACE_SELECTED_TEXT;
     }
   } else if ([value isKindOfClass:[NSNumber class]]) {
     if ([attribute isEqualToString:NSAccessibilityFocusedAttribute]) {
-      node_->GetDelegate()->SetFocused([value boolValue]);
+      data.action =
+          [value boolValue] ? ui::AX_ACTION_SET_FOCUS : ui::AX_ACTION_BLUR;
     }
   }
+  node_->GetDelegate()->AccessibilityPerformAction(data);

[dmazzoni, 2016/11/21 04:53:38]

Only do this if |data| is set, or add an "else" clause just in case
|value| is something else.

Don't make it a fatal error - this is an external API and we should fail
gracefully if passed an unexpected input - but don't make it possible
to call AccessibilityPerformAction with no action set.

[Patti Lor, 2016/11/21 23:24:39]

Now checking for AX_ACTION_NONE here, thanks.

 
   // TODO(patricialor): Plumb through all the other writable attributes as
   // specified in accessibilityIsAttributeSettable.